Metrics: histograms for aggregate share and collection job size in reports and batch aggregations

Open
#4,015 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
48/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
rust

Research direction

Review the existing aggregation job size instrumentation referenced in issue #2730 and trace how reports, collection jobs, aggregate shares, and batch aggregations are represented. Define metrics for collection-job and aggregate-share sizes in reports and batch aggregations, plus reports per batch aggregation; done means these metrics are emitted and expose the requested sizes and counts.

Written by the indexing model from the issue text.

Description

For a given task, collection job requests and responses and aggregate share requests and responses always have the same size, so we can't tell based on HTTP message size metrics whether handling an aggregate share requires summing up 10 batch aggregations DB rows or 10,000. We should emit a metric for the size of collection jobs and aggregate shares, both in number of reports and number of batch aggregations.

While we're instrumenting stuff, it would also be nice to get insight into how many reports there are per batch aggregation.

Previously, we did this for aggregation job size: https://github.com/divviup/janus/issues/2730

Dominant language
Rust
Stars
70
Forks
16
Avg merge
4h 36m
Merged PRs (30d)
30

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from divviup/janus

All issues in divviup/janus

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.