divviup / divviup/janus

Move datastore items related to leases into new module

Open
#3,946 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
70
Forks
16
Avg merge
4h 36m
Merged PRs (30d)
30

Description

#3945 adds a new janus_aggregator::core::datastore::leases module. There's a number of items from its parent module and datastore::models that could move into the new file, like the Acquired[Collection, Aggregation]Job types, Leased<T>, and a variety of methods on Transaction. We might also add janus_aggregator::core::datastore::leases_tests and janus_aggregator::core::datastore::models::leases.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the new janus_aggregator::core::datastore::leases module from #3945, then inspect the parent datastore module and datastore::models for AcquiredCollectionJob, AcquiredAggregationJob, Leased, and related Transaction methods. Check the proposed leases_tests and models::leases locations. Done means lease-related items are organized in the new modules without breaking existing tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
databases, distributed-systems
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.