divviup / divviup/janus

Add support for retry_http_request_notify in retries.rs to use DateTime-style Retry-After headers

Open
#3,943 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
70
Forks
16
Avg merge
4h 36m
Merged PRs (30d)
30

Description

In #3931, we're adding automatic retries to the retry_http_request_notify method, but because that method has no Clock, it cannot calculate Retry-After values using a DateTime-style header.

We should add that support by plumbing in the Clock.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in retries.rs at retry_http_request_notify and review issue #3931 for the automatic retry context. Trace how Clock is available to related retry paths, then verify that DateTime-style Retry-After headers can be handled through the added Clock support.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
networking
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.