divviup / divviup/janus

Consider disabling cascading delete of task_upload_counters/task_aggregation_counters

Open
#3,707 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
70
Forks
16
Avg merge
4h 36m
Merged PRs (30d)
30

Description

We currently have ON DELETE CASCADE on the foreign-key relationship between the internal counter metric tables and the tasks table. This probably isn't the right behavior, as I think subscribers can delete tasks in some scenarios. We may want to remove this cascading delete, or even denormalize the DAP task ID into these tables.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the schema definitions for task_upload_counters and task_aggregation_counters and their foreign-key relationship to tasks. Trace the subscriber task-deletion paths to establish whether counter rows must survive deletion, then compare the alternatives described in the issue. Done requires a decided approach and corresponding verified schema behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
databases
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.