divviup / divviup/janus

Re-enable divviup-ts tests once divviup-ts implements DAP-13

Open
#3,479 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
70
Forks
16
Avg merge
4h 36m
Merged PRs (30d)
30

Description

#3469 disabled divviup-ts tests, because there are breaking client changes between DAP-09 & DAP-13 and divviup-ts does not yet implement DAP-13.

We should update divviup-ts to implement DAP-13, and re-enable these tests with an updated container image. https://github.com/divviup/janus/blob/bf396e07ab041243669446e9ab955085faf204b4/integration_tests/src/client.rs#L147 is the right place to update the container image once it is available.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the changes from #3469 and integration_tests/src/client.rs at the referenced container-image line. First confirm that divviup-ts implements DAP-13, then update the container image and re-enable the disabled divviup-ts tests. Done means the updated integration tests pass against the DAP-13 client.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust, typescript
Domain
distributed-systems, testing-qa
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.