divviup / divviup/janus

Add timeouts to request handling

Open
#3,034 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
70
Forks
16
Avg merge
4h 36m
Merged PRs (30d)
30

Description

We may want to add timeouts to cancel request handling futures in addition to cancelling on disconnect (see #3033). It would make sense to set the timeout in Janus slightly shorter than the timeouts of any reverse proxies in front of it. Note that there are some situations, depending on the client, the HTTP protocol version, the OS, and when and how the disconnection happens, that may mean our server can't detect a disconnection.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating request handling futures and the existing disconnect-cancellation path referenced in #3033. Determine where a request timeout can be applied and how completion or cancellation is currently tested; done means request handling is also cancelled after the intended timeout without relying on disconnect detection.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
api, backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.