divviup / divviup/janus

Switch from janus_http_request_duration to http.client.request.duration

Open
#2,463 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

observability
Dominant language
Rust
Stars
70
Forks
16
Avg merge
4h 36m
Merged PRs (30d)
30

Description

We currently define our own histogram metric for latency and status of HTTP client requests, janus_http_request_duration. The name is a bit unfortunate, as it doesn't include "client" in it. We could adopt the OpenTelemetry HTTP semantic conventions and use http.client.request.duration. Note that we are already following SemCov for HTTP server metrics.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search the repository for janus_http_request_duration and inspect the code and tests that define or record this HTTP client histogram. The work is done when the metric uses http.client.request.duration consistently and its existing latency and status behavior remains covered.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
observability
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.