divviup / divviup/janus

Janus aggregator API always reports being able to run either role

Open
#2,175 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
70
Forks
16
Avg merge
4h 36m
Merged PRs (30d)
30

Description

The configuration endpoint in the Janus aggregator API is hard-coded to report that it can execute either the leader or helper role (1). But that's not necessarily true: if someone exclusively runs a janus_aggregator but not the other three components, they can't actually act as a leader. Worse, they will accept report uploads and collection job requests, but the task will silently fail, because aggregation jobs will never be scheduled or run, and collection jobs will never be run.

We could add a configuration option allowing aggregators to opt out of either role. Then the aggregator API could report the corresponding supported roles, and the DAP API endpoints could return some HTTP client error if e.g. a helper-only Janus receives an upload request.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with aggregator_api/src/routes.rs at the configuration endpoint cited in the issue, then trace the DAP API endpoints that accept report uploads and collection job requests. Determine how role configuration should be represented and how unsupported roles should be reported or rejected. Done means the configuration reflects enabled roles and unsupported requests return a client error instead of silently failing.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
api, backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.