divviup / divviup/janus

Aggregator API router is being called on all conns even after Aggregator router match

Open
#1,899 1 comment 0 reactions 1 assignee View on GitHub

@branlwyd is already working on this.

Since Sep 18, 2024.

Dominant language
Rust
Stars
70
Forks
16
Avg merge
4h 36m
Merged PRs (30d)
30

Description

This is confusing in debug logs. The computational cost of this extra router is very light (a single match against the prefix plus async overhead), but it probably makes sense to halt on match in whichever router is first. If someone used an empty prefix, both routers would run in sequence, which would likely have confusing and unexpected consequences

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.