TODOs regarding mockito and strict matching of DAP request bodies
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 70
- Forks
- 16
- Avg merge
- 4h 36m
- Merged PRs (30d)
- 30
Description
We have some comments in the aggregation job driver tests like the following:
This is fragile in that it expects the leader request to be deterministically encoded. It would be nicer to retrieve the request bytes from the mock, then do our own parsing & verification -- but mockito does not expose this functionality at time of writing.
Version 0.32.4 introduces a new Mock::with_body_from_request() that provides the incoming request to a callback, and takes the response body from the callback's return value.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the aggregation job driver tests containing the quoted comments and review Mockito 0.32.4's Mock::with_body_from_request() API. Replace the deterministic request-body matching described there with callback-based request parsing and verification, and confirm the affected tests still validate the expected DAP requests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- testing-qa
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100