divviup / divviup/divviup-api

Mismatching types between divviup-client and libprio-rs/janus

Open
#897 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
10
Forks
5
Avg merge
2h 41m
Merged PRs (30d)
66

Description

In divviup-client, we have types that don't cleanly match those of the janus and libprio-rs crates.

For instance, in Vdaf we have length and bits parameters that need to be converted to usize for use in libprio-rs. Ideally the divviup-client representations would match those of janus and libprio-rs, so the user doesn't need to handle .into()/.try_into()/as conversions.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing cli/src/tasks.rs and comparing its Vdaf representations with the corresponding types in divviup-client, janus, and libprio-rs. Identify the mismatched parameters such as length and bits, then confirm the work is complete when callers no longer need the described into(), try_into(), or as conversions.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
backend-api-design
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.