divviup / divviup/divviup-api

Should we always set min_batch_size == max_batch_size?

Open
#495 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

TBD/Design/Discussion phase
Dominant language
Rust
Stars
10
Forks
5
Avg merge
2h 41m
Merged PRs (30d)
66

Description

From https://github.com/divviup/divviup-api/issues/286#issuecomment-1631259780.

For fixed size queries, we prompt the user to specify a max batch size. We'll probably always recommend that the user set min and max equal to each other, thus making this field meaningless.

There's also an unspecified issue in the DAP specification for removing this ability entirely https://www.ietf.org/archive/id/draft-ietf-ppm-dap-06.html#section-4.1.2-6

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the linked divviup-api issue comment and DAP specification section 4.1.2-6. Determine whether fixed-size queries should continue exposing separate min and max batch sizes or remove that ability, then confirm the project behavior and scope before proposing a change.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
api, backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.