discord / discord/SimpleAST

Improve XML code highlighting

Open
#29 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Kotlin
Stars
382
Forks
33
Avg merge
18h 8m
Merged PRs (30d)
1

Description

The Code highlighting for the XML language is kinda odd looking, when compared to the desktop equivalent.

On mobile does it look like that right now (I use AMOLED Dark theme):
image

Meanwhile on Desktop (Windows) is it rendered like this:
image

It bothers me, that indend ending sections, like the </block> in our example, have a completely different text fill color, while all the other ones seem perfectly fine.
This should be corrected to have it more similar to the desktop version of the App.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the XML syntax-highlighting and rich-text rendering entry points in the Android library, then compare the behavior with the supplied mobile and desktop screenshots. Done when indented closing sections such as use a consistent fill color closer to the desktop rendering.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, kotlin
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.