dis-moi / dis-moi/backend

Prevent contributor dangerous mistake : a pipe without anything after or before

Open
#367 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
5
Forks
1
PR merge metrics
No merged PRs in 30d

Description

**Problem**
On bubble 1859, there was this regex line : `(nest.audio|nest.mini|home.mini|nest.hub|lenovo.smart.clock|lenovo.smart.display|homepod|) `

Contributor forgot one pipe at the end of his regex.
Consequence : It matched with all page of website listed in domain list.

Many users have bee annoyed during their navigation, stats were thus awful :
![image](https://user-images.githubusercontent.com/7824485/116536619-72af4b80-a8e5-11eb-8d9b-94aa18256f70.png)

Fortunaltly, during Q&A work, Julien saw the problem and alerted the team.
The false positive so named lasted 2 days.

![image](https://user-images.githubusercontent.com/7824485/116536801-aab68e80-a8e5-11eb-8aba-113e3aad91c2.png)

**Solutions**
1. In contribution BO, if a contributor writes `|)` or `(|` the system blocks him.
2. If a contribution has in an hour more than 10 views and a rate detail click / view < 3% during this hour, it alerts contribution@dismoi.io with the number of the bubble. (This solution needs to be discussed with contribution team and technical team to be refined)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.