dimforge / dimforge/simba

`RealField::min_value()` documentation does not match implementation

Open Beginner friendly
#86 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
347
Forks
39
PR merge metrics
No merged PRs in 30d

Description

Hi,

`min_value()` is implemented as

```rust
/// The smallest finite positive value representable using this type.
#[inline]
fn min_value() -> Option {
Some(<$T>::MIN)
}
```

But `MIN` is negative. `MIN_POSITIVE` might be the intended implementation if documentation is correct.

Contributor guide

No contributing guide indexed for this repository

Research direction

Search the repository for RealField::min_value and the implementation shown in the issue. Read the surrounding trait or macro definitions to determine whether the documentation or the returned value is authoritative, then update the mismatched part and verify the relevant checks pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
64/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.