dimforge / dimforge/salva

Asserts occur randomly and break the simulation

Open
#48 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
693
Forks
40
PR merge metrics
No merged PRs in 30d

Description

There are some cases when the asserts are hit, and stop simulation. The ask of this issue is, are all the asserts needed? Could the simulation be continued in any way, even if some things go wrong. Not sure about all, but I know sometimes some particles seems to almost explode and go out a lot, and then all stop. I would be ok with them exploding, I could lower some parameters, but maybe not all asserts are needed.
Eg an assert of where an index from array is out of bounds, thats needed. But if a value is 0 where a division by 0 happens, in that case you could put EPSILON instead of 0 and somehow continue the simulation.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.