dimforge / dimforge/bevy_rapier

`ColliderDebugColor` should contain a `Color`

Open
#572 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
1.6k
Forks
282
PR merge metrics
No merged PRs in 30d

Description

`ColliderDebugColor` now contains an `Hsla`, which means the user's colors now need to undergo conversion from

(User's color space if not `Hsla`) ->
`Hsla`->
`Color` (no color space conversion here) ->
(deep in Bevy's gizmo renderer, `LinearRgba`)

`bevy_rapier` also seems to convert from `Hsla` to `[f32, 4]` and back to `Hsla` for no discernible reason in `object_color` and e.g. `draw_line`.

Given that the ultimate destination of these colors is `Gizmos`, and `Gizmos` want `Color`, I think we should just use `Color`.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by tracing ColliderDebugColor and the object_color and draw_line paths mentioned in the issue, then compare them with the Gizmos color API. Check where Hsla and array conversions occur. Done means the debug-color path uses Color consistently and the redundant conversions are removed without changing rendered colors.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
computer-graphics, game-dev
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.