dimforge / dimforge/bevy_rapier

Make scene queries squawk when pipelines are disabled

Open
#213 1 comment 0 reactions 0 assignees View on GitHub
A-Integration C-Enhancement D-Medium P-Medium S-not-started
Dominant language
Rust
Stars
1.6k
Forks
282
PR merge metrics
No merged PRs in 30d

Description

I spent a long time debugging a situation where I'd turned off physics/query pipelines to spawn everything in a level, tried to move a system that needed the pipeline into that spawning state, and suddenly found my pipeline queries not returning objects they should have. Once I realized my mistake, the solution was obvious. But it took longer than it should have to get to that realization.

Could various `QueryPipeline` functions possibly log an error, panic, etc. if called when the physics pipeline is disabled? I don't think I care which they do--I just didn't remember that I'd disabled physics for legitimate reasons, and would have appreciated it if the scene queries I'd ran had at least told me they wouldn't do anything, even if only in debug builds.

Not sure if this should be in bevy_rapier or lower in the stack.

Thanks.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.