dimforge / dimforge/alga

InnerSpace Angle Implementation Bug

Open
#97 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
201
Forks
40
PR merge metrics
No merged PRs in 30d

Description

The implementation of `angle` function on trait `InnerSpace` is incorrect. When calculating `cang`, instead of multiplying the inner product by the norms of two vectors, it should be dividing them.

The correct calculation should be `let cang = prod.real().unscale(n1 * n2);`.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.