dimensionalOS / dimensionalOS/dimos
Flaky e2e: test_go_to_the_bed times out without reporting final position
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 4.5k
- Forks
- 808
- Avg merge
- 3d 5h
- Merged PRs (30d)
- 233
Description
dimos/e2e_tests/test_dimsim_spatial_memory.py::test_go_to_the_bed (self-hosted-large job) flakes with:
TimeoutError: Failed to get to position x=-3.567, y=-1.332
Example failure: https://github.com/dimensionalOS/dimos/actions/runs/30356553452/job/90265993009
The message reports the target, not where the robot ended up. lcm_spy.py:159 wait_until_odom_position computes distance on every odom message but throws away the last-seen position, so every flake is undebuggable.
Proposed fix:
- Include the last odom position and the minimum distance reached in the TimeoutError message.
- Evaluate a soft-failure margin: nav threshold is 2m/180s — decide whether ending within some larger margin of the bed (e.g. ≤3m) should warn/soft-pass instead of hard-fail.
Synced from DIM-1359 by stash
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with dimos/e2e_tests/test_dimsim_spatial_memory.py::test_go_to_the_bed and lcm_spy.py:159, where wait_until_odom_position calculates distance and raises the timeout. Reproduce or inspect the self-hosted-large failure, then make the error report the last odom position and minimum distance reached. Resolve and test the proposed soft-failure margin for results near the bed, with the e2e test passing and failures remaining diagnosable.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- robotics, testing-qa
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100