dimensionalOS / dimensionalOS/dimos

unitree-dds addition to toml calls cyclone-dds

Open
#1,974 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
4.5k
Forks
808
Avg merge
3d 5h
Merged PRs (30d)
233

Description

uv sync --all-extras --no-extra dds is not enought to exclude dds

uv sync --all-extras --no-extra dds --no-extra unitree-dds should be done. because, [unitree-dds] includes cyclone-dds, as unitree-sdk2py-dimos calls dds internally.

Solution
  • can include --no-extra unitree-dds to the installation, but this will be a big change across many files, and loger command is aesthetically bad
  • can include unitree-sdk2py-dimos under dds, and remove unitree-dds

Synced from DIM-844 by summer

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the dependency and extra definitions for dds, unitree-dds, unitree-sdk2py-dimos, and cyclone-dds, then reproduce the documented uv sync commands. Done means excluding dds does not install cyclone-dds through unitree-dds, with the chosen dependency arrangement reflected consistently across the affected files.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.