dimensionalOS / dimensionalOS/dimos
Unitree Go2 settings shouldn't be global settings but local module settings
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 4.5k
- Forks
- 808
- Avg merge
- 3d 5h
- Merged PRs (30d)
- 233
Description
dimos/robot/unitree/go2/connection.py
def make_connection(ip: str | None, cfg: GlobalConfig) -> Go2ConnectionProtocol:
connection_type = cfg.unitree_connection_type
if ip in ("fake", "mock", "replay") or connection_type == "replay":
dataset = cfg.replay_dir
depends on global config
while unitree go2 config should be local module config using standard dimos pydantic configs
dimos --replay --replay-dir=unitree_go2_bigoffice run unitree-go2
ask Sam how this would look with local module level config, we should make sure it's nice..
Synced from DIM-744 by summer
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in dimos/robot/unitree/go2/connection.py and trace how make_connection uses GlobalConfig, then inspect the standard dimos pydantic configuration pattern. Check the dimos --replay --replay-dir=unitree_go2_bigoffice run unitree-go2 entry point and ask Sam how the local module configuration should look. Done means Unitree Go2 settings no longer depend on global config and the replay command still works.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- robotics
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100