digitalocean / digitalocean/pydo

client.kubernetes.create_cluster does not implement registry_enabled as advertised

Open
#433 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
140
Forks
68
Avg merge
9h 52m
Merged PRs (30d)
7

Description

It appears that 0.10.0 (and earlier) does not correctly pick up the `registry_enabled` flag as documented in https://pydo.readthedocs.io/en/latest/pydo.aio.operations.html#pydo.aio.operations.KubernetesOperations.create_cluster

## To test:
Create a cluster using

```python
def test_create_cluster_with_registry_integration() -> None:
cluster = client.kubernetes.create_cluster({
'name': 'registry_enabled_test',
'region': 'ams3',
'version': '1.32',
'registry_enabled': True,
})

assert cluster['kubernetes_cluster']['registry_enabled'], 'Expected registry to be enabled'
```
However, you will find that this assertion fails. Would you please be so kind as to fix this and adopt this test in your test suite?

## Workaround
```python
def test_create_cluster_with_registry_integration() -> None:
cluster = client.kubernetes.create_cluster({
'name': 'registry_enabled_test',
'region': 'ams3',
'version': '1.32',
'registry_enabled': True,
})

client.kubernetes.add_registry({'cluster_uuids': [cluster['id'] for cluster in clusters['kubernetes_clusters']]})

assert cluster['kubernetes_cluster']['registry_enabled'], 'Expected registry to be enabled'
```

Thank you,
Rein

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.