digitalocean / digitalocean/go-workers2

Unique jobs queue option

Open
#26 4 comments 1 reaction 0 assignees View on GitHub
Dominant language
Go
Stars
141
Forks
37
PR merge metrics
No merged PRs in 30d

Description

Hey I was just tracing around and found this hard fork. Originally I hacked in these two features on top of your work in the soft fork of the go-workers lib, since I like handling errors rather than recovering from panics (which seems to be a common ruby/rails idiom).

I am planning on putting appropriate testing around these two features, but was wondering about getting some informal review of my implementation details.

If you are open to this, and honestly I am not really sure if it's okay because the original developer charges money for these features in his ruby gem, am I infringing on some kinda fuzzy line here?

Moving on, are you willing to give it a look over, and if so should I just open a tentative MR into your soft fork, or should I rebase my changelog on this repo and open an MR here for review?

Contributor guide

No contributing guide indexed for this repository

Research direction

The issue does not name any files, tests, or entry points, and asks for review of two existing features rather than specifying a change. First clarify the intended unique-jobs queue behavior, implementation scope, and whether a merge request should target this repository; done would require an agreed design and appropriate tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
15/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.