digitalocean / digitalocean/go-libvirt

suggested breaking change: add context.Context support to API

Open
#182 1 comment 2 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
1.1k
Forks
143
PR merge metrics
No merged PRs in 30d

Description

Client code would benefit a lot from context cancellation support. I suspect we could update the code generator to add context.Context parameters that many Go programmers might already be used to and thread those through to Libvirt.getResponse.

Perhaps this breaking change is the line we could cross to cut a v1 module of go-libvirt to avoid breaking client code in a confusing way.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.