digitalocean / digitalocean/droplet_kit

Inconsistent error handling

Open
#293 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Ruby
Stars
521
Forks
151
PR merge metrics
No merged PRs in 30d

Description

I'm noticing that certain resource requests have different error handling. For instance, returning a 422 for a volume action will raise a `FailedCreate` error, but a 429 response doesn't raise an error at all but returns a json string containing the body of the response. The [code for this resource](https://github.com/digitalocean/droplet_kit/blob/main/lib/droplet_kit/resources/volume_action_resource.rb) is pretty straightforward. Is there a reason for this approach?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.