digidem / digidem/secret-stream-http
Use `Readable.from` instead of `StreamxAsNodeDuplex`
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 0
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
We may be able to use Readable.from() instead of StreamxAsNodeDuplex to convert the streamx instance from @hyperswarm/secret-stream into something that Node's http server will be happy with. This would be better, because it reduces maintenance of this library.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading src/streamx-as-node-duplex.js and the code that passes the streamx instance to Node's HTTP server. Check whether Readable.from() handles the required stream behavior, then remove the adapter only if the HTTP path still works and the adapter is no longer needed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, node.js
- Domain
- api, backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100