digidem / digidem/comapeo-core

Make `SyncApi.prototype.start` and `.stop` asynchronous

Open
#786 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

post-mvp
Dominant language
JavaScript
Stars
24
Forks
6
Avg merge
1d 40m
Merged PRs (30d)
8

Description

We've run into some race conditions with the fact that these are synchronous.

See https://github.com/digidem/mapeo-core-next/pull/764#issuecomment-2312453209 for more detail.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the implementation of SyncApi.prototype.start and SyncApi.prototype.stop, then read the race-condition details in the referenced pull request comment. Trace their callers and existing tests before deciding how asynchronous completion should be represented. Done means both methods handle the reported races and have coverage for the affected startup and shutdown behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
api, distributed-systems
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.