digidem / digidem/comapeo-core-react

Add tests for read and write hooks

Open
#33 0 comments 0 reactions 1 assignee View on GitHub

@achou11 is already working on this.

Since Jan 23, 2025.

Dominant language
TypeScript
Stars
1
Forks
1
Avg merge
5m
Merged PRs (30d)
2

Description

Most of the work so far lives on this branch. I've committed to taking a data-first approach for now as it feels more straightforward, despite react testing library's preference for DOM-oriented testing. Been running into some annoying issues around React Query updates sometimes not being applied and available within a test, but otherwise things seem to work as expected.

There's going to be a good amount of overlap with how the e2e tests in core work. The one difference that I want to make sure is tested here is the end-user hook APIs we land on and making sure the behaviors of these hooks (e.g. invalidation, state updates, etc) are expected

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.