diffplug / diffplug/spotless

Prettier typescript act as tsx instead of ts

Open
#2,479 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
5.6k
Forks
559
Avg merge
1d 13h
Merged PRs (30d)
34

Description

I have this code and i saw a difference when running prettier using npm directly and when running using spotless

When using npm the code is formated like this
`export const myFunction = (`

But when using spotless the code change like this
`export const myFunction = (`

gradle configuration :
` typescript {
target 'src/**/*.ts'
prettier("${prettierVersion}")
.npmExecutable("${tasks.named('npmSetup').get().npmDir.get()}${npmExec}")
.nodeExecutable("${tasks.named('nodeSetup').get().nodeDir.get()}${nodeExec}")
.configFile('.prettierrc')
}`

npm run format command in package.json :
`"format": "prettier --config .prettierrc --ignore-path .prettierignore --write ./src/**",`

prettierrc tralingComa defined to "all"

i fixed by changing gradle configuration to this and now spotless format exactly as npm
`format 'typescript', {
target 'src/**/*.ts'
prettier("${prettierVersion}")
.npmExecutable("${tasks.named('npmSetup').get().npmDir.get()}${npmExec}")
.nodeExecutable("${tasks.named('nodeSetup').get().nodeDir.get()}${nodeExec}")
.configFile('.prettierrc')
}`

I think using predefined typescript format act as tsx format (i don't use tsx, but i saw that tsx require trailing coma in generics).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.