diffplug / diffplug/spotless

up-to-date checking on npm-based steps is too generous

Open
#2,140 2 comments 0 reactions 1 assignee Claimed by @simschla View on GitHub
bug
Dominant language
Java
Stars
5.6k
Forks
559
Avg merge
1d 13h
Merged PRs (30d)
34

Description

If you are submitting a **bug**, please include the following:

- [x] summary of problem

The npm-based steps don't capture their settings files in their state, which makes them too generous in claiming to be up-to-date. This applies to:

- `ESLintFormatterStep`
- `PrettierFormatterStep`
- `TsFmtFormatterStep`.

This bug was introduced in #2135 as part of the effort to make all steps roundtrip-serializable for Gradle.

- [x] spotless version
plugin-gradle 7.0, plugin-maven 3.0

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.