diffplug / diffplug/gitcasso

comment draft lags when defocusing tab

Open
#72 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
HTML
Stars
58
Forks
0
PR merge metrics
No merged PRs in 30d

Description

- open a comment
- type some stuff into it
- click the gitcasso popup
- BUG: the draft is not there
- close the popup and open it again
- now the draft is there.

The sequence of events is:

- open popup
- popup sends `GET_OPEN_SPOTS` to background
- background replies with `GetTableRowsResponse`
- because popup has focus, the tab lost focus
- tab notices and sends `LOST_FOCUS` event with updated draft
- but the rows were already sent

Workaround: if you defocus the text area manually by clicking somewhere else in the tab, and then click the popup, then the popup is up-to-date right away.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.