diem / diem/explorer

Explorer Tech Debt

Open
#5 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
7
Forks
12
PR merge metrics
No merged PRs in 30d

Description

**🤔 Why it's needed 👀**
As a developer on the Diem network, I want to be able to see clean, maintainable, tested code so I can have confidence in the software.

**✨ Things we'd like to improve 🛠**
- [ ] Remove all abbreviations from accessibility fields (ie. aria-label)
- [ ] Add contract tests to CI
- Need to figure out how to track tables in Hasura in CI so the Zeus client is generated properly

**🪦 Tech Debt Graveyard 👻**
- [x] Capitalize custom types
- [x] Convert Wiremock json strings to jsonBody json objects.
- [x] Document all `make` targets
- [x] Investigate typescript graphql libraries to replace our hand-rolled graphql client
- Zeus auto-generated GQL Client added by #74.
- [x] Contract test the acceptance test mock data with the graphql api
- `make contract_test` added by #74.
- [x] Always normalize addresses before making queries
- Similar to https://github.com/diem/explorer/blob/4c365b6d4d74e5844cca69514ff0137e03762723/src/Pages/LandingPage/LandingPage.tsx#L74
- [x] Deprecate Blockchain JSONRPC client
- [x] If the auto-generated BlockchainRESTClient works, deprecate the hand-rolled one, if it doesn't remove it
- Make sure you also replace the hand-rolled types used by the REST client (ie BlockchainAccountModule)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.