diegomura / diegomura/react-pdf
getWrap behaviour change in v4
- Dominant language
- TypeScript
- Stars
- 16.8k
- Forks
- 1.3k
- Avg merge
- 5h 6m
- Merged PRs (30d)
- 52
Description
In this change https://github.com/diegomura/react-pdf/commit/481b536f4ad145fb227829399b85a35838a506f8#diff-787134450138de88787ea4fed051cb798a2e3a5816955746ab7730617ae6d6e3R11
getWrap inside getWrap.ts was slightly altered resulting in different behaviour.
Now when passing an undefined wrap prop it is treated as `wrap=false`
Repro
[4.3.2 new behaviour](https://react-pdf.org/repl?code=3187b0760ce02e004d09e01b02984605e18194a4e5600b6592803a6002764043299002806f00a0618a012ca1402e19198016da8500e61cc001510001cf8022009c00180293c98017c00d2b18c904c82d4207087c040337050018b5411d13c3e01c8004b24400dc48760d400b4004220880026aeda30a08820146e00c4b6004c2900cccacaae5aba9a009400dccca090b08c00ee14d4329a18fc7500f48da68200ae88b412a230e1a850146dc0506d14dd3096142082303253321025e0d0bd20c0f5f47a003c00226b6d82c86050007c7a6c5b000ad4a2c8701c005ec8e8f20082002c1a676c3f3f5b006a1c6405460551aba12ad55ab7d7e7f49320001ea7002cbc0e0473a18180c82da35e148986c2605b7c4a2d1100c51db1b8d26136124c4593d1c72a4e2f18cba6fc1904d473331d4f6413cef4da6f2292cac5b369c2ae68bc994c94d23932b8472c50a8174a8917395f3594aa176b89baf17f2a5caa377299a6fd60b4e2a9d5abe512cd45bb55693baa5de6c37ba4d1a9f7db2dfeef41a837ea75eb1576ce6aa79ceb3587638ef8d475dbea247abd8998c3b8d919b746b511d4e17d3e1ccc8673c5cac160349bcd6613b69ac8aeba1dcf07dbd5b76d74bf5cec97ad03d6ecbbb2ddedb7fb1dd1dc78733c9d8fa73d8cd4fe72b8adaf3dcda2e2ee7dbb4e0793f9e5c4f573f00241370f0daee9f77e7fdf66cf9ba5fae5fc7ebd968f8daac7f7fe383eaf93e3bb969f9fe4078180581007de305deefa41b0621f050e07b7eb79a1cf921087a1239ee298a13fae1d86a17d911987917842e8fa11d446e505c1c4561a0731546916c56e1c6515c6b13c5bef47fe245f183bb1226ceb8a02c09d2b8b5cb70c2b89ecc001c1899c45330cc0004a3430c970ecb6290541807d050f43846b3a94000)
[3.4.5 old bheaviour](https://v3.react-pdf.org/repl?code=3187b0760ce02e004d09e01b02984605e18194a4e5600b6592803a6002764043299002806f00a0618a012ca1402e19198016da8500e61cc001510001cf8022009c00180293c98017c00d2b18c904c82d4207087c040337050018b5411d13c3e01c8004b24400dc48760d400b4004220880026aeda30a08820146e00c4b6004c2900cccacaae5aba9a009400dccca090b08c00ee14d4329a18fc7500f48da68200ae88b412a230e1a850146dc0506d14dd3096142082303253321025e0d0bd20c0f5f47a003c00226b6d82c86050007c7a6c5b000ad4a2c8701c005ec8e8f20082002c1a676c3f3f5b006a1c6405460551aba12ad55ab7d7e7f49320001ea7002cbc0e0473a18180c82da35e148986c2605b7c4a2d1100c51db1b8d26136124c4593d1c72a4e2f18cba6fc1904d473331d4f6413cef4da6f2292cac5b369c2ae68bc994c94d23932b8472c50a8174a8917395f3594aa176b89baf17f2a5caa377299a6fd60b4e2a9d5abe512cd45bb55693baa5de6c37ba4d1a9f7db2dfeef41a837ea75eb1576ce6aa79ceb3587638ef8d475dbea247abd8998c3b8d919b746b511d4e17d3e1ccc8673c5cac160349bcd6613b69ac8aeba1dcf07dbd5b76d74bf5cec97ad03d6ecbbb2ddedb7fb1dd1dc78733c9d8fa73d8cd4fe72b8adaf3dcda2e2ee7dbb4e0793f9e5c4f573f00241370f0daee9f77e7fdf66cf9ba5fae5fc7ebd968f8daac7f7fe383eaf93e3bb969f9fe4078180581007de305deefa41b0621f050e07b7eb79a1cf921087a1239ee298a13fae1d86a17d911987917842e8fa11d446e505c1c4561a0731546916c56e1c6515c6b13c5bef47fe245f183bb1226ceb8a02c09d2b8b5cb70c2b89ecc001c1899c45330cc0004a3430c970ecb6290541807d050f43846b3a94000)
You can see when comparing 3.4.5 and 4.3.2 the behaviour has changed
Contributor guide
Assessment
This issue has not been assessed yet.