diegomura / diegomura/react-pdf

remaining margin/padding bottom should be removed on new page

Open
#2,724 1 comment 0 reactions 0 assignees View on GitHub
new feature
Dominant language
TypeScript
Stars
16.8k
Forks
1.3k
Avg merge
5h 6m
Merged PRs (30d)
52

Description

**Is your feature request related to a problem? Please describe.**
I have a document that creates component with dynamic content. These components can span across multiple pages.
The logic I want:
If a component starts on a new page, it should start on top of it.
If there already is a component on a page, the next component should be rendered on the same page, but only if there is enough space (60px padding - margin broke the layout but thats already an open bug here) to do so.

**Describe the solution you'd like**
the Page or View component should have a prop like "cleanBreak". If that is true, when the pdf calculates a page break for the Page/View and that page break results because of margin/padding at last element, that margin element should not be continued on the next page. Therefore it is always a "clean" break

**Describe alternatives you've considered**
I tried just adding paddingBottom, but that resulted in sometimes new pages not starting at the top. And since I sometimes need 2 components on the same page, I cant have each in an individual Page either.

This would work if I use margin instead of padding, but margin leads a different bug, that the size for view components containing text is calculated wrong, see example here
![image](https://github.com/diegomura/react-pdf/assets/48676901/9196c969-e71c-45a5-88b9-c7e8a782254f)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.