dice-group / dice-group/gerbil

Tests are relying on external resources

Open
#304 0 comments 0 reactions 1 assignee View on GitHub

@LukasBluebaum is already working on this.

Since Jan 30, 2020.

SHK type:bug
Dominant language
Java
Stars
231
Forks
55
PR merge metrics
No merged PRs in 30d

Description

Description

Some of our JUnit tests rely on external resources making them unstable. This should be avoided since it may lead to errors that are not bound to the implementation and it leads to timeouts in Travis (e.g., see https://travis-ci.org/dice-group/gerbil/builds/480844126).

List of affected tests

The list can be easily constructed (or checked again), by checking out the project, disabling all networking and rerun all tests.

Proposed fixes

Further suggestions are welcome 😃

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.