diasurgical / diasurgical/devilution

Globals with incorrect type

Open
#1,324 0 comments 2 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
9k
Forks
920
PR merge metrics
No merged PRs in 30d

Description

The following is a list of globals that have the wrong type when compared to the PSX SYM 3 file. Some might just need to be changed into a form of boolean, some may already be correct since the PSX versions deviate some from the PC release but we need to test and compare this.

- [x] extern bool TransList[8];
- [x] extern char gszVersionNumber[5];
- [ ] extern char itemactive[127];
- [ ] extern char itemavail[127];
- [ ] extern char left[8];
- [ ] extern char MonstAvailTbl[112];
- [ ] extern char offset_x[8];
- [ ] extern char offset_y[8];
- [ ] extern char opposite[8];
- [ ] extern char right[8];
- [ ] extern char rnd10[4];
- [ ] extern char rnd20[4];
- [ ] extern char rnd5[4];
- [ ] extern char rnd60[4];
- [ ] extern char shrineavail[26];
- [ ] extern char totalmonsters;
- [ ] extern int Qtalklist[16][11];
- [ ] extern short monstactive[200];
- [ ] extern short monstkills[200];
- [x] extern unsigned char bannerflag;
- [x] extern unsigned char boyloadflag;
- [x] extern unsigned char chrflag;
- [ ] extern unsigned char dflags[40][40];
- [ ] extern unsigned char InStoreFlag;
- [ ] extern unsigned char InvItemHeight[180];
- [ ] extern unsigned char InvItemWidth[180];
- [x] extern unsigned char leveldebug;
- [x] extern unsigned char lvlbtndown;
- [x] extern unsigned char ManashieldFlag;
- [x] extern unsigned char ManashieldFlag2;
- [x] extern unsigned char MissilePreFlag;
- [x] extern unsigned char monstdebug;
- [x] extern unsigned char nBlockTable[2049];
- [x] extern unsigned char nMissileTable[2049];
- [x] extern unsigned char nTransTable[2049];
- [x] extern unsigned char panelflag;
- [ ] extern unsigned char PauseMode;
- [x] extern unsigned char qtextflag;
- [x] extern unsigned char sbookflag;
- [x] extern unsigned char scrollflag;
- [ ] extern unsigned char setlvltype;
- [ ] extern unsigned char sgbMouseDown;
- [x] extern unsigned char storeflag;
- [x] extern unsigned char talkflag;
- [x] extern unsigned char trigdebug;
- [x] extern unsigned char uitemflag;
- [x] extern unsigned char visiondebug;
- [ ] extern unsigned long CowPlaying;
- [ ] extern unsigned long gdwAllTextEntries;
- [ ] extern unsigned long PanBtnStr[8];
- [ ] extern unsigned short dungeon[48][48];
- [ ] static unsigned char AmShiftTab[8];
- [ ] static unsigned char chrbtn[4];
- [x] static unsigned char cineflag;
- [ ] static unsigned char HR1;
- [ ] static unsigned char HR2;
- [ ] static unsigned char HR3;
- [ ] static unsigned char panbtn[8];
- [ ] static unsigned char sgbPlrTalkTbl[2];
- [ ] static unsigned char sgbSentThisCycle;
- [ ] static unsigned char VR1;
- [ ] static unsigned char VR2;
- [ ] static unsigned char VR3;
- [ ] static unsigned long scrolltexty;
- [ ] static unsigned long sgdwLastTime;
- [ ] static unsigned long sgdwPlayerLeftReasonTbl[2];
- [ ] static unsigned long sgdwProgress;
- [ ] static unsigned long sgLastScroll;

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.