di-sukharev / di-sukharev/opencommit

[Bug]: editing last line results in commit message inaccurate about the change

Open
#427 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
JavaScript
Stars
7.5k
Forks
445
Avg merge
18m
Merged PRs (30d)
2

Description

Opencommit Version

3.2.2

Node Version

N/A

NPM Version

N/A

What OS are you seeing the problem on?

Mac

What happened?

See commit message and diff https://github.com/kaovilai/dotfiles/commit/223f940bb0d04c0dfad3f06ddd3ab274a1848ecc

Expected Behavior

Diff is about

alias restart-displaylink='osascript -e "quit app \"DisplayLink Manager\""; while pgrep DisplayLinkUserAgent > /dev/null; do sleep 0.1; done; open -a DisplayLink\ Manager'

Current Behavior

Diff is about

alias velero-makecontainer-velero-restore-helper-cluster-arch='make container IMAGE=$(ghcr_notag) VERSION=velero-restore-helper-$(current-branch)-$(rev-sha-short)-$(cluster-arch-only) && docker push $(ghcr_notag):velero-restore-helper-$(current-branch)-$(rev-sha-short)-$(cluster-arch-only) && echo $(ghcr_notag):velero-restore-helper-$(current-branch)-$(rev-sha-short)-$(cluster-arch-only)'
Possible Solution

maybe if last line change is detected have the model (or another pre-processing) ignore second last line.

Steps to Reproduce

No response

Relevant log output

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the commit and diff at https://github.com/kaovilai/dotfiles/commit/223f940bb0d04c0dfad3f06ddd3ab274a1848ecc with the expected and current behavior described here. Trace the entry point that turns the final-line diff into a commit message, reproduce the mismatch, and verify that the generated message describes the actual changed line.

Written by the indexing model from the issue text.

Assessment

Tech stack
git, javascript
Domain
cli, devtools
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.