dherault / dherault/serverless-offline

contentHandling

Open
#1,752 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
5.3k
Forks
811
Avg merge
2d 4h
Merged PRs (30d)
3

Description

## Bug Report

**Current Behavior**

serverless-offline is looking for contentHandling in the wrong place.

It used to be located events:http:contentHandling when we used serverless-apigwy-binary

However it has been moved to events:http:response:contentHandling now that it is natively supported within serverless.

In order to make it work both offline and when deployed I have to double up the configuration as shown below:
However, this results in a warning when deploying:

Warning: Invalid configuration encountered
at 'functions.getApplePass.events.0.http': unrecognized property 'contentHandling'

- file: serverless.yml

functions:
getApplePass:
handler: apple/handler.getApplePass
memorySize: 128
timeout : 30
events:
- http:
path: /{version}/passes/{passTypeIdentifier}/{serialNumber}
integration: lambda
contentHandling: CONVERT_TO_BINARY
method: get
cors: true
private: false
request:
parameters:
paths:
version: true
passTypeIdentifier: true
serialNumber: true
response:
contentHandling: CONVERT_TO_BINARY
headers:
Access-Control-Allow-Origin : "'*'"
Content-Type: "'application/vnd.apple.pkpass'"

plugins:
- serverless-offline

provider:
runtime: nodejs18.x
stage: prod

**Expected behavior/code**

**Environment**

- `serverless` version: 13.3.0
- `serverless-offline` version: 13.3.0
- `node.js` version: 8x
- `OS`: Mac OS 13.6.1

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.