x/net/trace causing DCE to be disabled
Open
Nobody has claimed this yet.
Stale
- Dominant language
- Go
- Stars
- 15.8k
- Forks
- 1.3k
- Avg merge
- 2m
- Merged PRs (30d)
- 1
Description
Describe the bug
x/net/trace import at https://github.com/hypermodeinc/badger/blob/a9a63e263d9aa6a82d8b640bc6396afc4696dd6b/y/event_log.go#L8 is causing DCE (deadcode elimination) to be disabled for any app depending on this module
To Reproduce
Steps to reproduce the behavior:
- build badger or an app depending on badger
- DCE is disabled
Expected behavior
DCE is enabled
Screenshots
If applicable, add screenshots to help explain your problem.
Environment
- OS: [e.g. macOS, Windows, Ubuntu]
- Language [e.g. AssemblyScript, Go]
- Version [e.g. v0.xx]
Additional context
Add any other context about the problem here.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at y/event_log.go#L8 and inspect how the x/net/trace import affects builds of Badger and dependent applications. Reproduce by building Badger or a dependent app, then verify that dead-code elimination is enabled after the issue is addressed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100