dgkf / dgkf/R

Suggestion for Naming convention

Open
#178 0 comments 0 reactions 0 assignees View on GitHub
theme-internals
Dominant language
Rust
Stars
145
Forks
5
PR merge metrics
No merged PRs in 30d

Description

Due to all the interior mutabilty I sometimes get confused whether methods modify an object via interior mutability or whether they clone the object, modify it and return it as a new value.

In pytorch, methods that mutate an object in-place end with an underscore.
What do you think about applying this naming convention here as well?
For example the `Rep::materialize_inplace()` method would then be called `materialize_()`

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.