IMF lower limit, variables defined during setup
Open
@bd-j is already working on this.
Since Feb 28, 2021.
- Dominant language
- Python
- Stars
- 76
- Forks
- 45
- PR merge metrics
- No merged PRs in 30d
Description
The FSPS setup module reads imf_lower_bound from the imf_lower_limit variable at instantiation and uses the former variable when computing the weight of the lowest mass isochrone point. However, only the latter variable is accessible through python-fsps. In practice this means that changing imf_lower_limit to any value below the mass of the lowest-mass isochrone point leads to incorrect calculation of its weight.
The best fix for this is probably in fsps itself, but it's probably worth checking sps_setup.f90 for any similar cases.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.