dfe-analytical-services / dfe-analytical-services/eesyapi.R

Tidy up parsing into a single response_parse function

Open
#58 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
R
Stars
3
Forks
2
PR merge metrics
No merged PRs in 30d

Description

## Is your feature request related to a problem? Please describe.
Currently we have `post_dataset()` and `get_dataset()` both doing parsing independently, to reduce duplication and streamline our functions a bit for easier testing and maintenance we should break out a separate `response_parse()` eske function.

## Describe the solution you'd like
A new function that handles the parsing for both post and get functions.

## Describe alternatives you've considered
None, might be other approaches too.

## Additional context
GitHub conversation on PR about this https://github.com/dfe-analytical-services/eesyapi/pull/54/files#r1813192121

https://github.com/dfe-analytical-services/eesyapi/pull/54/files#r1813192121

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.