dfe-analytical-services / dfe-analytical-services/dfeshiny

Cookies panel issues

Open
#53 4 comments 0 reactions 1 assignee Assigned to @cjrace View on GitHub
bug
Dominant language
R
Stars
7
Forks
3
Avg merge
8h 54m
Merged PRs (30d)
2

Description

## Describe the bug
Three current bugs from following the vignette (potential to split into separate issues):
- [ ] 1. Automatically redirects to the cookies page (due to the ID issue Rich mentions below, we should update the guidance to cover it to prevent others hitting it without realising)
- [ ] 2. Once accepted there is excess whitespace at the top of the screen
- [ ] 3. There is not enough padding on the left of the text and buttons inside the banner
- [ ] 4. There is spill of some kind causing a horizontal scroll bar to appear
- [ ] 5. Need to include an example of using with a hidden tab opened from the footer

## How to reproduce

Have a draft PR with a branch with the current functions in on the apps provider dashboard - https://github.com/dfe-analytical-services/apprenticeships-provider-dashboard/pull/100

## Expected behaviour
- The cookies banner to stay at the top until a user accepts.
- When a user accepts the page doesn't change.
- There is no whitespace left once cookie option set.
- The link to more cookies information works with a bslib hidden tab and we have an example for this.

## Screenshots

Excess whitespace
![image](https://github.com/user-attachments/assets/1a98beda-87be-4977-83b7-8150f6577961)

Lack of margin / padding for cookies banner
![image](https://github.com/user-attachments/assets/bd319e86-34bc-41cf-826e-4825643f733b)

Spillover on right hand side causing horizontal scroll bar
![image](https://github.com/user-attachments/assets/384c33b5-940c-4cdf-9f0e-a0404162e48e)

## Additional context
Suspect we'll want to update the vignette and the code to fix these, some will be bugs with the package, others just a lack of detail in the guidance.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.