dfe-analytical-services / dfe-analytical-services/dfe-published-data-qa

[Feature]: Add specific checks in for filter hierarchies

Open
#150 0 comments 0 reactions 0 assignees View on GitHub
enhance existing code new feature
Dominant language
R
Stars
4
Forks
1
PR merge metrics
No merged PRs in 30d

Description

### Description

Once they are ready to launch within EES itself, we need to update a raft of checks and add in test data for filter hierarchies.

One of the things we need to not forget in this is that with hierarchies EES always expects a 'Total' value to be present!

### Use case

As a publisher
I want to be able to reliably check filter hierarchies data
So that I can be confident I have got the structure of the data correct before uploading into EES and be confident it will behave as expected for users

### Why this is important

Without this the hierarchies work doesn't add anything, this is critical to making it happen

### Additional Context

Need to check the final agreed approach in metadata, and add specific test files for it.

Will need to adapt existing tests, though we should be careful that all existing test files and data still also pass - we need to support files that don't have filter hierarchies reliably as well

### Required updates

- parent_filter is added as an allowable entry in the meta data
- "Total" must be present in any filter with an assigned parent filter (we should be able to evolve the existing Total test for this)
- Any columns with a parent filter must not have a custom filter_default
- All entries in the parent_filter column must be unique
- All entries in the parent_filter column must have a corresponding entry in col_name

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.