devicons / devicons/devicon

[FEATURE REQUEST] Automatically check if .svg files contain width and height attributes

Open
#1,549 0 comments 0 reactions 0 assignees View on GitHub
devops enhancement
Dominant language
CSS
Stars
11.8k
Forks
2.4k
Avg merge
5d 9h
Merged PRs (30d)
4

Description

### I have searched through the issues and didn't find my problem.

- [X] Confirm

### Problem

Icons should use the `viewbox` attribute instead of the `width` and `height` attributes. Atm we have to check this manually when reviewing a PR, but it can easily be automated with `check-bot`

### Possible Solution

Add checks to `check-bot` and respond with an error message if any .svg files in a PR contain width and/or height attributes

### Additional information

_No response_

Contributor guide

Open the contributing guide

Research direction

Start by locating the existing check-bot checks for pull requests and review how they report validation errors. Add a check for .svg files containing width or height attributes, and verify that a pull request with those attributes receives an error while compliant SVG files pass.

Written by the indexing model from the issue text.

Assessment

Domain
ci-cd, testing
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.