devicons / devicons/devicon

[FEATURE REQUEST] Make `check-bot` check that base and alias have different values.

Open
#1,486 1 comment 1 reaction 0 assignees View on GitHub
devops enhancement
Dominant language
CSS
Stars
11.8k
Forks
2.4k
Avg merge
5d 4h
Merged PRs (30d)
3

Description

### I have searched through the issues and didn't find my problem.

- [X] Confirm

### Problem

Currently it's possible to add a new entry to `devicon.json` with the following code:
```json
"aliases": [
{
"base": "plain",
"alias": "plain"
}
]
```
Notice how the base and alias have the same value (`plain`). This does not make any sense, since the aliases attribute serves as a way to generate multiple font icon class name from just one SVG file ([ref the documentation for aliases](https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60#aliases-and-aliasobj)). So having plain as both an alias and base would only duplicate the class name.

Therefore we should make a check that fails if the base and alias are the same.

### Possible Solution

It should be possible to add an extra check to our existing `check-bot`, in this script: https://github.com/devicons/devicon/blob/master/.github/scripts/check_icon_pr.py

### Additional information

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.