developmentseed / developmentseed/osm-teams

Allow changing attribute type when creating it

Open
#462 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
29
Forks
4
PR merge metrics
No merged PRs in 30d

Description

When I add a new attribute to a team, I am able to select the attribute type:

![image](https://github.com/developmentseed/osm-teams/assets/478237/2cce2ccc-ed03-4b01-94bb-fbe695c16f7b)

However, if I select the wrong type by mistake, I am unable to change it, even though the attribute hasn't been created yet:

![image](https://github.com/developmentseed/osm-teams/assets/478237/22f9e7f4-7e91-4002-b9c1-7a256b5b441c)

I realize that it's deliberate that an attribute's type is not editable after it's created; quoting https://github.com/developmentseed/osm-teams/issues/264#issue-1204400697 and https://github.com/developmentseed/osm-teams/pull/259#pullrequestreview-931623191:

> We should disallow modifying property type after it is created as there will be no way of parsing existing data (changing date to telephone, for e.g.)

...but in this case it should be safe because the attribute has not been actually created yet.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the team attribute creation form and the attribute-type selector described in the issue. Verify the selector's behavior before saving versus after creation; done means a new, unsaved attribute can change type, while an existing attribute's type remains locked.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.