developmentseed / developmentseed/osm-teams

Enhancements to Profile forms

Open
#264 3 comments 0 reactions 1 assignee Claimed by @kamicut View on GitHub
Category: Design Identity and UI Type: Enhancement
Dominant language
JavaScript
Stars
29
Forks
4
PR merge metrics
No merged PRs in 30d

Description

From #259 review by @vgeorge

- We should disallow modifying property type after it is created as there will be no way of parsing existing data (changing date to telephone, for e.g.)
- There is no error message if property creation fails. I think we can fix this on a separate PR after https://github.com/developmentseed/osm-teams/pull/256 is merged, which includes toasts
- A more accurate label for the button "Add your profile" might be "Edit your team profile"
- If possible it would be good to move profiles keys table to a reusable component as it looks the same in org/team pages

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.