developmentseed / developmentseed/obstore

Should we be running `object_store` tokio tasks on the runtime provided by `pyo3-async-runtimes`?

Open
#577 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
810
Forks
42
Avg merge
1d 15h
Merged PRs (30d)
6

Description

`object_store` has a [`SpawnedReqwestConnector`](https://docs.rs/object_store/latest/object_store/client/struct.SpawnedReqwestConnector.html), which allows for all requests made by `object_store` to be done on the provided runtime. Should we be passing that in?

```rs
let connector = SpawnedReqwestConnector::new(get_runtime().handle().clone());
builder = builder.with_http_connector(connector);
```

Right now, is there a new tokio runtime created for each client..?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.